Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add krook (CNCF staff) as a maintainer on the servicedesk repo. #272

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

krook
Copy link
Member

@krook krook commented Aug 8, 2023

I'm in a new role focused on developer satisfaction so I'm looking to improve the servicedesk README and resolve/merge the outstanding PR.

Signed-off-by: Daniel Krook <krook@linux.com>
@clowarden
Copy link

clowarden bot commented Aug 8, 2023

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Github

  • user krook is now a collaborator (role: maintain) of repository servicedesk

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@clowarden
Copy link

clowarden bot commented Aug 8, 2023

Validation succeeded

✅ The proposed configuration changes are valid!

Configuration changes

Github

  • user krook is now a collaborator (role: maintain) of repository servicedesk

🔸 Please review the changes detected as they will be applied immediately once this PR is merged 🔸

@krook
Copy link
Member Author

krook commented Aug 8, 2023

We can squash the 3 commits. I had to amend to include my latest GPG signing key and mark the latest as verified.

@jeefy jeefy added the ok-to-test Apply if PR is validated safe to test label Aug 10, 2023
@jeefy jeefy merged commit 26e3092 into cncf:main Aug 10, 2023
4 of 5 checks passed
@krook krook deleted the access/krook branch August 10, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Apply if PR is validated safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants